game menu system very slow

BlitzMax Forums/BlitzMax Beginners Area/game menu system very slow

kaiserpc

(Posted 2009) [#1]

The menu I have written for my game seems to be very slow / laggy when I click on an option (or press a key).

Moving up and down via the mouse or cursor keys is fine, it's just sometimes slow when I click on an option. For example if I click on "Quit" it may take a couple of seconds to recognise this, by which point I've moved up to "load game" and rather than quitting it tries to load a game. Then the next time I do the same thing it could be fine.

I think it must either be my event handler, or the that I have multiple "if" statements within my "case"

The menu I'm using needs to work for both mouse and keyboard controls.

I'd be grateful if someone could have a look at my code, or provide some code for a working mouse and keyboard menu system

thanks in advance :-)

Function mainMenu:Int()
	Local tmr:Int = MilliSecs()
	Local startGame:Int = 0
	Local quitGame:Int = 0
	Local refreshTimer:TTimer = CreateTimer(60) 'kicks in the EventID so we can use the key handler in a Case
	menuSelection.cursorY = (yMiddle - 175)
	menuSelection.cursorX = (xMiddle - 100)
	Local tmr2:Int = MilliSecs()
	'set up the diffculty default level from the gameInfo file
	If gameInfo.level = 1 Then
		menuselection.diffLevelFrame = 0
	ElseIf gameInfo.level = 2 Then
		menuSelection.diffLevelFrame = 1
	Else If gameInfo.level = 3 Then
		menuSelection.diffLevelFrame = 2
	EndIf
	
	While startGame = 0 And quitGame = 0 And (Not AppTerminate())
		Cls
		menuSelection.drawBackground(xMiddle, yMiddle, gameInfo.xRes)
		menuSelection.drawTitle(xMiddle, yMiddle)
		menuSelection.drawMenu(xMiddle, yMiddle)

		'Mouse Controls
		'If the mouse has moved then show it on screen
		If MouseX() <> mouseSelect.initialX Or MouseY() <> mouseSelect.initialY Then
			ShowMouse()
			'work out the y value of the mouse and set the value used below to highlight
			'the cursor position
			If MouseY() > (yMiddle - 175)+50 And MouseY() <= (yMiddle - 125)+50 Then
				menuSelection.cursorY = (yMiddle - 125)
			Else If MouseY() > (yMiddle - 125)+50 And MouseY() <= (yMiddle - 75)+50 Then
				menuSelection.cursorY = (yMiddle - 75)
			Else If MouseY() > (yMiddle - 75)+50 And MouseY() <= (yMiddle - 25)+50 Then
				menuSelection.cursorY = (yMiddle - 25)
			Else If MouseY() > (yMiddle - 25)+50 And MouseY() <= (yMiddle + 25)+50 Then
				menuSelection.cursorY = (yMiddle + 25)
			Else If MouseY() > (yMiddle + 25)+50 And MouseY() <= (yMiddle + 75)+50 Then
				menuSelection.cursorY = (yMiddle + 75)
			Else If MouseY() > (yMiddle + 75)+50 And MouseY() <= (yMiddle + 125)+50 Then
				menuSelection.cursorY = (yMiddle + 125)
			Else If MouseY() > (yMiddle + 125)+50 And MouseY() <= (yMiddle + 175)+50 Then
				menuSelection.cursorY = (yMiddle + 175)
			Else If MouseY() > (yMiddle + 175)+50 And MouseY() <= (yMiddle + 225)+50 Then
				menuSelection.cursorY = (yMiddle + 225)
			EndIf	
		EndIf

		'highlight cursor position
		Select menuSelection.cursorY
			Case (yMiddle - 125)
				highLightText(1,0,0,0,0,0,0,0)
			Case (yMiddle - 75)
				highLightText(0,1,0,0,0,0,0,0)
			Case (yMiddle - 25)
				highLightText(0,0,1,0,0,0,0,0)
			Case (yMiddle + 25)
				highLightText(0,0,0,1,0,0,0,0)
			Case (yMiddle + 75)
				highLightText(0,0,0,0,1,0,0,0)
			Case (yMiddle + 125)
				highLightText(0,0,0,0,0,1,0,0)
			Case (yMiddle + 175)
				highLightText(0,0,0,0,0,0,1,0)
			Case (yMiddle + 225)
				highLightText(0,0,0,0,0,0,0,1)
		End Select	
		Flip

		WaitEvent()
		Select EventID()
		Case EVENT_TIMERTICK
			Select True
				Case KeyDown(KEY_DOWN)
					menuSelection.down(yMiddle)
				Case KeyDown(KEY_UP)
					menuSelection.up(yMiddle)
				Case KeyDown(KEY_RETURN), KeyDown(KEY_SPACE), KeyDown(KEY_RIGHT), MouseHit(1), JoyDown(0,0)
					If menuselection.cursorY = (yMiddle - 125) Then
						'startGame
						startGame = 1
						pickScenario()
						Return 0
					Else If menuselection.cursorY = (yMiddle - 75) Then
						'load game
						Local ret:Int = loadGame("gameInfo.sav", "galanors.sav", "shadowLords.sav", "Fortress.sav", "runeRing.sav", 1)
						startGame = 1
						Return 1
					Else If menuselection.cursorY = (yMiddle - 25) Then 
						'change difficulty
						If gameInfo.level = 1 Then
							gameInfo.level = 2
							menuSelection.diffLevelFrame = 1
						Else If gameInfo.level = 2 Then
							gameInfo.level = 3
							menuSelection.diffLevelFrame = 2
						Else If gameInfo.level = 3 Then
							gameInfo.level = 1
							menuselection.diffLevelFrame = 0
						EndIf						
					Else If menuselection.cursorY = (yMiddle + 25) Then 
						'graphic options
						graphicOptions()
					Else If menuselection.cursorY = (yMiddle + 75) Then 
						'define keys
						FlushKeys
						defineKeys()
					Else If menuselection.cursorY = (yMiddle + 125) Then 
						'introduction
						gameInfo.glMovementSound.Play
						displayInstructions("readme.txt")
					Else If menuselection.cursorY = (yMiddle + 175) Then 			
						'instructions
						displayBackStory("backgroundStory.txt", "races.txt")
					Else If menuselection.cursorY = (yMiddle + 225) Then 
						'quit
						quitGame = 1
						Return 2
					EndIf
					Delay 100 'so joystick doesn't go repeatedly
			End Select
		End Select
		FlushKeys
		FlushJoy(0)
		
		'update the mouse values on the main menu
		If MilliSecs() > tmr + 500 Then
			tmr = MilliSecs()
			mouseSelect.initialX = MouseX()
			mouseSelect.initialY = MouseY()
		EndIf	
	Wend
	'if we get here the user has clicked on the "x" to close the window
	quitGame = 1
	Return 2
End Function

xlsior

(Posted 2009) [#2]

Rather than pulling mousex and mousey continuously, you may want to put it in a variable once and do the successive comparisons against it?

ImaginaryHuman

(Posted 2009) [#3]

That shouldnt make it slow.

Are you suffering from frame lag? ie is your driver showing you a frame which was rendered several frames ago?

plash

(Posted 2009) [#4]

Could it possibly be from WaitEvent()?

kaiserpc

(Posted 2009) [#5]

I was thinking it might be the waitevent, so how do I change it to make it less laggy?

Gabriel

(Posted 2009) [#6]

Use PollEvent instead.

From the docs:

If there are no events in the event queue, WaitEvent halts program execution until an event is available. 

If there are no events in the event queue, PollEvent returns 0.

kaiserpc

(Posted 2009) [#7]

okay I'll try replacing my waitEvent with pollEvent - thanks

kaiserpc

(Posted 2009) [#8]

I've replaced the waitEvent with pollEvent but it still seems as laggy. Any other ideas?

Jesse

(Posted 2009) [#9]

The problem might be in your logic. Can you post a working sample?

MGE	(Posted 2009) [#10]

What is your frame rate before and during the menu?

kaiserpc

(Posted 2009) [#11]

Sorry for not replying - haven't been on my home PC for a couple of days - probably won't get the chance to look at it again till the weekend.

I must be doing something stupid as most of the other examples I've searched for on here seem to use waitevent() and then catch event_timertick() fine. I need to spend some time debugging this error properly

Also it's not consistently slow - when the game first loads it seems fine. It seems to be slower after exiting out of a game back to the main menu.

Using pollEvent instead of waitEvent seems to make the slowdown of the menu happen less frequently - although it still happens!

The actual error is that when you are over a menu item i.e. quit and you press return or click the mouse button I would expect the program to exit straight away. However it takes up to 5 seconds for the program to respond to the mouse click, during which time the user could move the mouse to the next menu item. The program then rather than execute the "Quit" command will execute the menu item that the cursor is currently highlighted over. So it is still responding to the single mouse click and therefore picking it up from the event queue (I'm not pressing the mouse button again) - it's just taking ages to respond to it. But the whole screen hasn't slowed down because moving the mouse still highlights the other menu options as quickly as normal - it just doesn't respond quickly to the mouse click - very strange!! (Note: the movement of the mouse up/down isn't handled in the waitevent loop)

thanks for the suggestions so far ...

TaskMaster

(Posted 2009) [#12]

Are you taking ALL events out of the queue each loop?

My guess is that you are taking one event then looping, then one event, then looping. Problem is, you are generating more than one vent per loop. So, they are building up and it seems like your app is lagging. You have to make sure you take ALL of the events out of the event queue each loop.